Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed variables to reflect test results #23

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Renamed variables to reflect test results #23

merged 2 commits into from
Jun 7, 2020

Conversation

jonasbn
Copy link
Contributor

@jonasbn jonasbn commented May 16, 2020

Renamed the variable to reflect the states of the tests.

This request originates from the dialogue with @subtlepseudonym and review of PR #18

I hope you find it useful.

@jonasbn jonasbn mentioned this pull request May 16, 2020
Open
@jonasbn
Copy link
Contributor Author

jonasbn commented May 21, 2020

@subtlepseudonym who is responsible for the actual merge of the PR?

@subtlepseudonym
Copy link
Contributor

Hopefully, I will be. @rakyll appears to have offered me maintainer status in #21, but hasn't given me write access yet.

@rakyll
Copy link
Owner

rakyll commented Jun 6, 2020

There are some conflicts now, can you please resolve? Otherwise, LGTM.

@jonasbn
Copy link
Contributor Author

jonasbn commented Jun 6, 2020

I do not know if it was a Git hiccup but the conflict did not capture the change in line 104-105 with the color handling for fail, but it has been changed as part of the conflict resolution

@rakyll rakyll merged commit 29d015f into rakyll:master Jun 7, 2020
@rakyll
Copy link
Owner

rakyll commented Jun 7, 2020

Thanks!

rakyll added a commit that referenced this pull request Jun 8, 2020
@rakyll
Fix the colors broken by #23
e60feff
@jonasbn
Copy link
Contributor Author

jonasbn commented Jun 8, 2020

I was looking at the release history and it seems my PR broke something, which resulted in release 0.0.4.

I am not sure as too what broke and why, I was very careful with my first PR and I tested thoroughly before submitting, but I am a Go n00b and I might have missed something.

I hope it has not caused too much inconvenience, I have updated my other PRs from master, where applicable and have done some more testing.

Anyway thanks for accepting my PR, it means a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subtlepseudonym subtlepseudonym subtlepseudonym approved these changes

@rakyll rakyll rakyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasbn @subtlepseudonym @rakyll